search

oppiliappan / statix

lints and suggestions for the nix programming language
https://git.peppe.rs/languages/statix/about
MIT License
557 stars 21 forks source link

Support macOS #7

Closed antifuchs closed 2 years ago

antifuchs commented 2 years ago

I tried statix on my mac, but couldn't because the flake only enables x86_64-linux. I imagine this might be useful to others, so here's a little diff.

Note that the libiconv addition is necessary so that the rust crate compiles on Darwin; I'm not sure why this is different from Linux, but a c compile step fails without it.

reckenrode commented 2 years ago

For what it’s worth, statix also builds and runs on aarch64-darwin (if it’s in the list of supported systems).

oppiliappan commented 2 years ago

For what it’s worth, statix also builds and runs on aarch64-darwin (if it’s in the list of supported systems).

Ah I see, in that case I am open to adding that as well to the list of supported systems.

oppiliappan commented 2 years ago

@antifuchs big thanks for working on this PR, and testing on darwin targets! Left a couple of minor suggestions.

cmacrae commented 2 years ago

Nice! I just forked with the intention of adding Darwin support and figured I'd better check if anyone else had started already - very glad to find this. Thanks @antifuchs 🙌

antifuchs commented 2 years ago

Addressed the two bits of feedback. I'm not sure why the PR shows up as having other changes on it, though: Did master change non-fast-forwardably?

oppiliappan commented 2 years ago

@antifuchs yeah, I made a couple of bad commits. No worries however, I can still merge this. I'll edit the commit history appropriately.

oppiliappan commented 2 years ago

Thanks!