search

oppo-us-research / SpacetimeGaussians

[CVPR 2024] Spacetime Gaussian Feature Splatting for Real-Time Dynamic View Synthesis
https://oppo-us-research.github.io/SpacetimeGaussians-website/
Other
585 stars 43 forks source link

[preprocess] Remove duplicate code and simplify script/pre_* #65

Closed remmel closed 2 months ago

remmel commented 2 months ago

Hello,

I'm willing to rework the script/pre_* code to

Are you PR welcome? I want to avoid to have my fork to different from yours as you still work on it and bring my modifications to the community. (Other simpler PR adding downscale during preprocessing I've just pushed https://github.com/oppo-us-research/SpacetimeGaussians/pull/64)

Thanks a lot for your paper, what you've done is amazing! you make possible to have real 3D video (6dof) 🤩

lizhan17 commented 2 months ago

Hi remmel, Thank you for your work ! Could you keep the original pre_n3d and rename your pre_n3d to other name, like pre_n3d_with_scale ? pre_n3d is for reproducing purpose. resolution and number of frames are fixed in the pre_script.

remmel commented 2 months ago

Hi Li,

I replied here https://github.com/oppo-us-research/SpacetimeGaussians/pull/64 as there is related to that PR, and would like to put here a more general discussion.

What do you think about my initial comment (minimize the duplicated code and use pathlib) ?