update the submodule url to use https url

[remmel]

If the user uses git clone https://github.com/remmel/SpacetimeGaussians.git --recursive instead of git clone git@github.com:remmel/SpacetimeGaussians.git --recursive, it is needed to have the submodule uses the https git url version. Note that using git clone https://... can be used if the user don't have ssh git keys or don't have them registered in his github account.

Thus it will fix that message error and let an user which don't have ssh keys being able to clone the repo:

Cloning into 'SpacetimeGaussians'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists

[remmel]

could have directly done in https://github.com/oppo-us-research/SpacetimeGaussians/pull/71

[lizhan17]

could have directly done in #71

Hi remmel,

have you try the command of clone in another machine without any git setup ?

git clone https://github.com/oppo-us-research/SpacetimeGaussians.git --recursive

it will cause error on my computer for mmcv folder.

[remmel]

Hi,

Yes if I remember, if git is not setup it failed. That's why I added that PR after. You should merge that PR.

If I'm wrong can you share your error message? I'll try that tomorrow.

Regards,

[lizhan17]

Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:open-mmlab/mmcv.git' into submodule path '/mnt/2t/SpacetimeGaussians/thirdparty/mmcv' failed Failed to clone 'thirdparty/mmcv' a second time, aborting

I used the latest version. I remmeber we approved that pr request.

I am thinking just not use recursive clone. and let users git clone mmcv in the third party folder.

[remmel]

Hello,

You merged the 1st PR #71 which handle normal case. But that 2nd PR #72 must be merged too; has it handle the case when the ssh key has not be configured. (I created that 2nd PR after has I figured it out after - you have same error has I had).

As you can see in the main branch, it uses git@github.com submodule instead of https://github.com. git@github.com like clone/submodule can only be used when we are a ssh registered github user, even when it is a public repo; I guess.

https://github.com/oppo-us-research/SpacetimeGaussians/blob/7c9fd0f430e34cd53a368938eb03ef71b9b8595b/.gitmodules#L3

That fix is done by that PR: https://github.com/oppo-us-research/SpacetimeGaussians/pull/72/commits/3e6bd3f30fa4375a151ea555b15951b05d8f2954

[lizhan17]

it works now. thank you !