search

opprop / checker-framework-inference

Inference of pluggable types for Java
6 stars 13 forks source link

Use standalone z3-turnkey dependency instead of jar files #402

Closed zcai1 closed 2 years ago

zcai1 commented 2 years ago

Loading z3 is an existing issue on mac: https://github.com/Z3Prover/z3/issues/294 and they will probably not fix it.

Therefore, this PR suggests using https://github.com/tudo-aqua/z3-turnkey to simplify the process of loading and using z3.

wmdietl commented 2 years ago

From the branch name I assume this specifically fixes build issues on Macs. As CI passes, things are okay on Linux. Please let me know if this fixes the Mac issues successfully.

zcai1 commented 2 years ago

From the branch name I assume this specifically fixes build issues on Macs. As CI passes, things are okay on Linux. Please let me know if this fixes the Mac issues successfully.

Yes, it's working now for me (maybe @al3xliu should double check). I'm not sure if we should add a CICD task for mac because it seems this repo is not using z3.

al3xliu commented 2 years ago

Yes, it works well.