search

opprop / checker-framework-inference

Inference of pluggable types for Java
6 stars 13 forks source link

Enforce `@TargetLocations` meta-annotation #413

Closed AndrewShf closed 6 months ago

AndrewShf commented 1 year ago

Once https://github.com/eisop/checker-framework/pull/339 lands in opprop/checker-framework, this PR updates CFI.

AndrewShf commented 1 year ago

This recent failure is due do wrong choice of CheckerFramework version git clone -b enforce-targetlocations -q --single-branch --depth 1 https://github.com/AndrewShf/checker-framework.git /home/runner/work/checker-framework-inference/checker-framework-inference/../checker-framework

As seen in the pipeline log file, when building CFI, it chose the eisop version enforce-targetlocations branch CheckerFramework as the dependency. However, CFI is a bit outdated and still needs opprop version CheckerFramework as the dependency. Delete enforce-targetlocations branch in eisop CF would help, as build script will pick the opprop master branch at this time.

AndrewShf commented 1 year ago

Oh, I still need to sync the eisop targetlocations changes to this opprop master branch to make the CI pass...

Ao-senXiong commented 6 months ago

I will cherry pick these commits as I am updating opprop to 3.39 now.