opprop / checker-framework-inference

Inference of pluggable types for Java
6 stars 13 forks source link

Replace broken APIs #423

Closed Ao-senXiong closed 1 year ago

Ao-senXiong commented 1 year ago

I have encountered a lot of errors while I am build the project. I try to fix them in this PR.

Also, in https://github.com/eisop/checker-framework/blob/ed990541a50116e8e5676062219aba2a0a3efe88/docs/CHANGELOG.md?plain=1#L180 createAnnotationMap and createAnnotationSet are removed from the project. However, they are heavily used in this inference project. We should have a discussion about whether bring them back to EISOP or not.

wmdietl commented 1 year ago

Thanks for looking into this! opprop/checker-framework builds against opprop/checker-framework, which I unfortunately haven't updated with eisop/checker-framework changes in a bit. After the next eisop release, I'll update opprop and then we can look into fixing these incompatibilities.

Ao-senXiong commented 1 year ago

Thanks for looking into this! opprop/checker-framework builds against opprop/checker-framework, which I unfortunately haven't updated with eisop/checker-framework changes in a bit. After the next eisop release, I'll update opprop and then we can look into fixing these incompatibilities.

Thanks. In my local branch https://github.com/Ao-senXiong/checker-framework-inference/tree/test-build, I have a successful build and test running with my EISOP/checker-framework branch https://github.com/Ao-senXiong/checker-framework/tree/test-build. Simply just add back the methods and replace the apis in here