search

opprop / checker-framework-inference

Inference of pluggable types for Java
6 stars 13 forks source link

Update to EISOP #425

Closed Ao-senXiong closed 7 months ago

Ao-senXiong commented 1 year ago

This is the attempt to update opprop checker-framework-inference project to based on the newest version of eisop check-framework.

Ao-senXiong commented 1 year ago

@wmdietl Hi Werner, can you take a look at this PR? I am not sure how to change the downstream tasks to pass all the checks. It seems that some inference failed.

wmdietl commented 1 year ago

Thanks for working on this! I would suggest splitting this up into multiple PRs. opprop/cf is currently on Version 3.28.0-eisop1. Make a separate PR for each EISOP release since then and make sure that each upgrade individually works. This will make it easier to see at what point this issue is introduced and will make the history in opprop/cf easier to reproduce. So start with an update to 3.32.0-eisop1 and have corresponding branches in all opprop repositories. Does that sound like a good approach?

Ao-senXiong commented 1 year ago

Thanks for working on this! I would suggest splitting this up into multiple PRs. opprop/cf is currently on Version 3.28.0-eisop1. Make a separate PR for each EISOP release since then and make sure that each upgrade individually works. This will make it easier to see at what point this issue is introduced and will make the history in opprop/cf easier to reproduce. So start with an update to 3.32.0-eisop1 and have corresponding branches in all opprop repositories. Does that sound like a good approach?

OK, sounds good. Thanks for the advice.

Ao-senXiong commented 7 months ago

Close as there is a new PR https://github.com/opprop/checker-framework-inference/pull/435.