search

opral / inlang-cli

Issue tracker repo for the CLI
0 stars 0 forks source link

rewrite lint rule decoration feature based on lix validation rules #15

Closed felixhaeberle closed 1 month ago

felixhaeberle commented 1 month ago

Description

@samuel.stroschein has made a decision to prematurely remove lint rule functionality from the inlang sdk and move the functionality/responsibility to lix, calling it "lix validation rules".

This decision leads to Sherlock not being able to offer lint rules anymore (unless we have shipped Lix validation rules) which not only hurts our users in the meantime of a prerelease but also adds double or tripple the work – for negative value.

On the other hand, Lix validation rules could be a great concept but is currently not spec'ed out, nobody is working at it currently and it seems that it has low priority, seemingly lower than building a host.

Proposal

Revert the decision, build lix validation rules & only after release Sherlock on SDK v2. Everything else results in work done thrice & damaging user trust.

samuelstroschein commented 1 month ago

Disagree. Release Sherlock. Validation rules take too long.

I am okay with shipping utility functions that simulate validation rules. See MESDK-204.

@felix.haeberle what are the rules you are missing? Missing translations seems to be the only crucial one

felixhaeberle commented 1 month ago

forced concensus: we will ship lint rules as utility functions. therefore build utility functions in the sdk. later change it to lix validation rules. creates thrice the effort & work not done at the right place but unblocks sherlock & fink fn. cc @niklas.buchfink

samuelstroschein commented 1 month ago

i agree with the consensus (but disagree with your wording. the effort of utility functions is trivial compared to lix validation rules)

felixhaeberle commented 1 month ago

progress can be tracked in SHERL-113 – closing this.