[Bug] Branch switching results in error related to ForkSyncing

opral / inlang-fink

Issue tracker for fink

0 stars 0 forks source link

[Bug] Branch switching results in error related to ForkSyncing #18

Closed NiklasBuchfink closed 2 months ago

NiklasBuchfink commented 2 months ago

Context

A repo with a fork parent is trying to run forkStatus
The branch is switched
Error is thrown

Proposal

This seems to occur in State.tsx in the forkStatus resource and its initialValue.

cc @jan.johannes

NiklasBuchfink commented 2 months ago

Another option might be, that the branch is not available in the fork parent. We should probably only check the status for the main/master branch.

NiklasBuchfink commented 2 months ago

I have tested this assumption and it was right. It always fails if the branch does not exist in the parent repo and there is nothing to compare.

NiklasBuchfink commented 2 months ago

I propose to:

[X] Silence the errors by not exposing them to the user. Notify the user if the feature is available and updates are available

If we only enable this feature, if it is a main or master branch, it won't be available for forks of a feature or translation branch. So we want to keep it. Even if this would reduce the amount of data transmitted.

NiklasBuchfink commented 2 months ago

Fixed with: https://github.com/opral/monorepo/commit/fb10c85353bf0e5059ef932679fbf820c5a96dbe