Improve sorting strategy - Githubissues

opral / inlang-message-ui-components

Issue tracker for UI components

0 stars 0 forks source link

Improve sorting strategy #86

Closed NilsJacobsen closed 4 months ago

NilsJacobsen commented 5 months ago

Current approach: When a variant gets added or a match is changed it gets sorted into its correct position

Downside:

Already wrong position is not getting corrected
Weird jumping around

Proposal1: Sort all entries only before rendering. Adding and renaming doesn't change anything; sorting can be triggered manually if it gets wild.

Pro:

No weird row jumping/ focus field randomness
Self-adjusting with initial render
When needed, manual sorting is possible

Cons:

Manual reordering trigger

Proposal2: Only sort in the frontend. Make sure that a saving saves the message in the old order

Pro:

No weird row jumping/ focus field randomness
Self-adjusting with initial render
When needed, manual sorting is possible, also different kinds of sorting are working
No reflection in the storage layer

Cons:

Manual reordering trigger

NilsJacobsen commented 4 months ago

Explanation Loom: https://www.loom.com/share/db19be66c7b24a43b38df65d8fbe4500

NilsJacobsen commented 4 months ago

I agree that having the sorting only in the UI makes the most sense. Persisting order in a distributed system like ours is very hard
- by Loris DM

NilsJacobsen commented 4 months ago

Sorting update https://www.loom.com/share/2efbb4f79d374b879595c3253ab4a33d

TL;DR:

Proposal 2
only sort in ui
no jumping rows