search

opral / inlang-paraglide-js

Tree-shakable i18n library build on the inlang ecosystem.
https://inlang.com/m/gerre34r/library-inlang-paraglideJs
23 stars 0 forks source link

custom NextLink component doesn't forward ref #105

Closed NurbekGithub closed 2 months ago

NurbekGithub commented 2 months ago

opral/monorepo/inlang/source-code/paraglide/paraglide-next/src/app/Link.tsx

it creates a visual bug for some ui component libs (mantine.dev) and might also cause some other regressions in react

https://github.com/opral/inlang-paraglide-js/assets/24915724/c839db11-fecf-4ed5-a0c9-8eec96992ddf

I tested locally and used React.forwardRef to a NextLink component and it worked as expected. PR incoming

LorisSigrist commented 2 months ago

Good catch! Thank you. Excited for the PR!

NurbekGithub commented 2 months ago

Here you go @LorisSigrist https://github.com/opral/monorepo/pull/2694; but, I was not able to run test scripts from monorepo root.