search

opral / inlang-paraglide-js

Tree-shakable i18n library build on the inlang ecosystem.
https://inlang.com/m/gerre34r/library-inlang-paraglideJs
52 stars 1 forks source link

LANG_COOKIE_NAME doesn't follow rfc6265 standards #234

Closed juliuskreutz closed 1 month ago

juliuskreutz commented 1 month ago

Hi,

As per rfc6265 4.1.1 a cookie name must conform to the token syntax, which doesn't allow for the use of separators (e.g. :).

https://github.com/opral/monorepo/blob/main/inlang/source-code/paraglide/paraglide-sveltekit/src/constants.js#L8C33-L8C49 is creating problems with any runtime, that enforces the recent standards or any program, that uses the cookie npm package (because of this line).

I ask, that you either change the value to a rfc6265 conforming one or that you make this constant overwrite/edit able. Thank you

samuelstroschein commented 1 month ago

thanks for reporting this. should be fixed via https://github.com/opral/monorepo/pull/3155