search

opral / inlang-paraglide-js

Tree-shakable i18n library build on the inlang ecosystem.
https://inlang.com/m/gerre34r/library-inlang-paraglideJs
42 stars 0 forks source link

sveltekit plugin is broken since vite@5.2.0-beta.1 #41

Closed ZerdoX-x closed 6 months ago

ZerdoX-x commented 6 months ago

Original issue (since it was not intended to be a breaking change from vite side) was opened here: https://github.com/vitejs/vite/issues/16245

I have created the issue here, in case it can be solved on paraglide side, and so people could know if they stumble upon this, the current solution is to downgrade to vite@5.2.0-beta.0 or vite@5.1.6

UPD: I have tried to reproduce the issue without sveltekit, no luck

arxpoetica commented 6 months ago

I came here to post the same thing. Here's a reproduction of the bug, pre-and-post v5.1.6 Vite:

https://github.com/arxpoetica/inlang-sveltekit-vite-bug

I tried to reproduce this on StackBlitz for easier debugging, but that was creating issues on its own.

LorisSigrist commented 6 months ago

Thanks for the repro, that's always really helpful!

LorisSigrist commented 6 months ago

Seems like this bug was caused by a downstream issue in one of our our dependencies that was surfaced by a change in how vite loads the config. Will be fixed in the next release

ZerdoX-x commented 6 months ago

Seems like this bug was caused by a downstream issue in one of our our dependencies that was surfaced by a change in how vite loads the config. Will be fixed in the next release

@LorisSigrist seems like no need to fix anything. issue was fixed in https://github.com/vitejs/vite/pull/16246

LorisSigrist commented 6 months ago

There _was_ a legitimate issue in paraglide, it just happened to be surfaced by a bug in vite. Either being fixed solves the issue. Great to see that the vite bug was fixed!

Thanks for the through issue + follow up!

arxpoetica commented 6 months ago

Can confirm this was fixed with the Vite fix.