Closed pago93 closed 5 months ago
I found some cases where the adapter was accidentally removing trailing slashes.
In the linked PR I fixed those & added a bunch of tests to ensure that trailingSlashes are preserved if present on all link-transformations. That should fix any issues. The example project is now using trailingSlash="always"
and everything seems to be working perfectly.
Can confirm it is working now with v 0.5.22
.
Thank you very much for the fast response!
No problem! If it's working in 0.5.22
then I found some additional issues. Those will be fixed in 0.6.0
.
I just realized that the PR is only linked in Linear and not on Github. I was referring to this: https://github.com/opral/monorepo/pull/2542
It seems like there's still a little bug. Directly opening the root with another language gets me a 404. Other addresses work fine.
https:\\my-site\
works with the default language. https:\\my-site\de
gets me a 404. https:\\my-site\de\x
albeit is working.https:\\my-site\
and switching to language to de
works and gets me the correct version of https:\\my-site\de
Just the initial loading doesn't work. Switching languages when the app is loaded does seem to be working fine.
Good catch, on it
New PR, should fix the issue https://github.com/opral/monorepo/pull/2543
v6.0.1
fixes the issue (hopefully for real this time)
The reroute hook does not work if
export const trailingSlash = 'always';
is set in+layout.ts
.It behaves like no route is present at all:
Would be great to get this working. In hosting scenarios with
@sveltejs/adapter-static
this setting is sometimes inevitable.