search

opral / inlang.com

This repo is for collecting issues around inlang.com (https://github.com/opral/monorepo/tree/main/inlang/source-code/website)
1 stars 0 forks source link

"edit this page on github" is hardcoded to the opral monorepo #80

Closed samuelstroschein closed 1 month ago

samuelstroschein commented 1 month ago

Context

Clicking on edit this page for third party products like https://inlang.com/m/neh2d6w7/plugin-hechenbros-xcstrings leads to a 404 https://github.com/opral/monorepo/blob/main/https://cdn.jsdelivr.net/npm/inlang-plugin-xcstrings@latest/README.md.

CleanShot 2024-05-30 at 11.13.38@2x.png

Proposal

Don't hardcoded the location of edit this page on github.

NilsJacobsen commented 1 month ago

Thanks for the ping.

It is not hardcoded, but it's using a weak condition. Works for example for this external app: https://inlang.com/m/fnhuwzrx/paraglide-remix-i18n/

NilsJacobsen commented 1 month ago

Gonna fix it

NilsJacobsen commented 1 month ago

Oh well his repo is privat, that's why he used a npm link.
I removed the link for npm links.