opral / monorepo

lix (change control system) && inlang (globalization ecosystem for software built on lix)
https://opral.com
Apache License 2.0
1.25k stars 111 forks source link

can't run `npm run dev` because turborepo has issues #680

Closed samuelstroschein closed 1 year ago

samuelstroschein commented 1 year ago

Problem

I can't run npm run dev because plugin:dev is blocking turborepo from proceeding somehow. I tried:

Expected behavior

npm run dev should start a server at localhost:3000.

Steps to reproduce

  1. run npm run dev from the root of the monorepo.

Additional information (screenshots?)

CleanShot 2023-05-08 at 19 32 16@2x
samuelstroschein commented 1 year ago

It might be worth it to remove tsup.

I had numerous other issues with tsup before. A separation like ide-extension and ide-extension-plugin might be an easy way to:

  1. avoid different environment-build-related issues, see https://github.com/inlang/inlang/issues/679 which should be solved by separating the inlang plugin from the vite plugin
  2. the inlang plugin build system from plugin-template can be used, ensuring that the SDK plugin will work
  3. the version mismatching is (maybe) improved because inlang won't import from @inlang/sdk-js anymore but @inlang/sdk-js-plugin for example. I am reluctant about the benefit of 3 though.
samuelstroschein commented 1 year ago

@ivanhofer given that you started on #690, you agree on separating the inlang plugin from the vite plugin?

ivanhofer commented 1 year ago

Yes, it makes things easier and more consistent. But it is not the problem of this issue. So splitting it had no impact on the npm run dev bug.

ivanhofer commented 1 year ago

Like I already mentioned in the discord: @inlang/sdk-js is not the issue. It just happens to be (mosten times) the last log line that get's written. Delete the dev script from any random package.json and npm run dev will work again. I think turborepo is the issue here

samuelstroschein commented 1 year ago

I can confirm that removing any dev script resolves the issue. What an odd bug. Investigation is pending.