oprypin / crsfml

Crystal bindings to SFML multimedia/game library
https://oprypin.github.io/crsfml
zlib License
350 stars 14 forks source link

Add missing SF::Ftp overloads to login and connect methods #7

Closed alanwillms closed 9 years ago

alanwillms commented 9 years ago

This PR adds:

ftp.login # no arguments
ftp.connect(ip_address, 21) # address and port
ftp.connect(ip_address) # address only

According to the default values defined here:

http://www.sfml-dev.org/documentation/2.3.1/classsf_1_1Ftp.php

oprypin commented 9 years ago

I just added this. CONTRIBUTING.md

Sorry, but this pull request edits autogenerated files.

+ I actually already wrote the same functions but then got discouraged seeing how many functions with defaults the Network module has.

oprypin commented 9 years ago

https://github.com/BlaXpirit/crsfml/commit/ad9e46128ec1b00ef6d72a7e2b7689b643350a89

alanwillms commented 9 years ago

I should have paid more attention. Thank you for fixing.