search

ops4j / org.ops4j.pax.exam2

Pax Exam is a testing framework for OSGi
https://ops4j1.jira.com/wiki/spaces/PAXEXAM4/
Apache License 2.0
84 stars 100 forks source link

Remove dependency of reflection for TestNG #1112

Closed krmahadevan closed 1 month ago

krmahadevan commented 4 months ago

The PaxExam listener makes use of reflection to disable configuration methods.

This is NOT needed because the TestNG API has Provided setters via which these can be set.

The reason why this change is required is because TestNG in its upcoming version is going to be Changing the data type of these two attributes viz “m_beforeTestMethods” and “m_afterTestMethods”

krmahadevan commented 4 months ago

Note: I tried to sign up to jira to log a ticket, but I am having difficulties with it.

I see this error (it looks like I still need to get permission for this project in jira)

image
oliverlietz commented 4 months ago

@krmahadevan, Thanks! All OPS4J projects switched from Jira to GitHub Issues.

krmahadevan commented 4 months ago

@oliverlietz - Ah ok! I was referring to the instructions detailed here which said need Jira ticket.

Please let me know if we need a github issue for this PR because it's not fixing anything but just changing how the listener interacts with TestNG. For an end user it shouldn't really matter because the functionality would still remain the same.

krmahadevan commented 2 months ago

ping @oliverlietz - Can you please let me know if there's anything pending from my side that needs to be completed so that this PR can be merged?

oliverlietz commented 1 month ago

@krmahadevan, In future, please create a GitHub issue, follow the Boy Scout Rule and sign your commits. I've incorporated your patch as part of #1117. Thanks!