ops4j / org.ops4j.pax.exam2

Pax Exam is a testing framework for OSGi
https://ops4j1.jira.com/wiki/spaces/PAXEXAM4/
Apache License 2.0
84 stars 100 forks source link

DefaultExamSystem should not use Files.deleteRecursively(File) [PAXEXAM-351] #484

Closed ops4j-issues closed 12 years ago

ops4j-issues commented 12 years ago

Former user created PAXEXAM-351

Guava marked this method as deprecated in r10 and removed it in r11 (as per their release policy) because it is not possible to implement correctly (http://code.google.com/p/guava-libraries/issues/detail?id=365).


Affects: 2.3.0 Fixed in: 2.3.1, 2.4.0 Votes: 0, Watches: 1

ops4j-issues commented 12 years ago

Toni Menzel commented

Thats interesting. We will use our own recursive delete then - even though its not 100% safe as stated in the guava issues thread.
I will see if we can upgrade to guava latest then.
Thanks for reporting.
If you have the time: feel free to upgrade (new task) after fixing this (e.g. by using FileUtils.delete from org.ops4j.base/ops4j-base-io project e.g.)

ops4j-issues commented 12 years ago

Former user commented

Fixed on commit https://github.com/ops4j/org.ops4j.pax.exam2/commit/be4d383eec2cd258c3eb016d2ba2a799c735b4a8

ops4j-issues commented 12 years ago

Former user commented

It resolved the issue.

ops4j-issues commented 12 years ago

Andreas Pieber commented

needs to be applied on 2.3.1 too; the problem is if a runtime system contains a newer version of guava, as e.g. Apache Karaf, this will lead to the usual method missing exceptions elsewise

ops4j-issues commented 12 years ago

Andreas Pieber commented

btw, finally this appears rather as a bug since pax-exam cannot run in case a different guava version is used.