search

ops4j / org.ops4j.pax.logging

The OSGi Logging framework implementation. Supports SLF4J,LOG4J,JCL etc.
https://ops4j1.jira.com/wiki/spaces/paxlogging/overview
Apache License 2.0
47 stars 79 forks source link

Source code JARs are incomplete #531

Closed wborn closed 11 months ago

wborn commented 1 year ago

It is annoying to debug Pax Logging code because the third party code is missing from the source code JARs.

E.g. if you debug pax-logging-log4j2 the code of log4j-core is missing from the source code JAR. So while debugging you first have to figure out what dependency version is used and then continuously switch between the pax-logging-log4j2 and log4j-core source code JARs while stepping through the code.

There are probably similar issues while debugging pax-logging-logback.

grgrzybek commented 1 year ago

I agree - I've been doing it for almost 10 years ;) With proper version of original Log4j2/Logback on debug path it's easier. I didn't have time to look at it, but feel free to submit a PR :)

wborn commented 1 year ago

10 years is a lot! :upside_down_face:

I see the POM has commented parts regarding the source code. Maybe you already gave it a try but it didn't work well?

grgrzybek commented 1 year ago

I don't exactly remember what happened 4 years ago ;) But it could be a good base for a PR...

wborn commented 12 months ago

But it could be a good base for a PR

I think the XML in the POM got commented when the maven-ant-plugin was upgraded to 3.0.0 @grgrzybek.

https://maven.apache.org/plugins/maven-antrun-plugin/

Major Version Upgrade to version 3.0.0

Please note that the following parameters have been completely removed from the plugin configuration:

  • tasks: use target instead;

With a few tweaks it worked again and I was able to use similar constructs for adding all other missing source code in #533.

grgrzybek commented 12 months ago

Thanks for the PR - at first and last glance it's perfect - I just didn't have time to merge it ;) I'm quite busy recently, so give me some time.