Closed ops4j-issues closed 8 years ago
ops4j-issues
commented
8 years ago Jan Kreutzfeld commented
FYI: for testing purposes, i recompiled the pax-web-spi 4.2.4 bundle with a cache max size of 10000. Now, the actual size of the cache is roughly 500 and my application works fine.
ops4j-issues
commented
8 years ago Achim Nierbeck commented
thanks for the input, right now I'm thinking of a nice way to get the configs from the main config file there ... that would need to be passed a long chain ... so I need to find something smoother :wink:
ops4j-issues
commented
8 years ago Christoph Läubrich commented
Just wondering: Should a LRUCache not vanish entries when it is full and maybe reload them later?
ops4j-issues
commented
8 years ago Achim Nierbeck commented
yes ... that's something that made me wonder too ...
especially the message "Please check that your keys are immutable" seems to be strange, oth it seems to be 100 unique keys ...
ops4j-issues
commented
8 years ago Christoph Läubrich commented
Maybe Jan Kreutzfeld cann check if there are any duplicate resources? Its seems to replace chromeAll.css or something similar but I'm not that familiar with LRUCache.
For Caching purpose I use Google Guava Cache that has a nice Loader interface and several options for evicting entries by size, time or access contraints, but introducing a new dependecy might not be wanted ...
It still might be a sync-issue as the exception suggested.
ops4j-issues
commented
8 years ago Achim Nierbeck commented
Just did take a closer look on the exported cache list.
I find it rather strange that it actually contains a lot of entries where there are keys but no values bound to it. Especially something like String.java=[]
I would make sure those entries are actually not added to the cache, maybe we can work on those to actually skip to add inside pax-web
ops4j-issues
commented
8 years ago ops4j-issues
commented
8 years ago Jan Kreutzfeld commented
The problem still occurs after your fix. It might very well be a synchronization issue. When adding the synchronized keyword to the ResourceDelegatingBundleClassLoader#addToCache method, i can no longer reproduce the exception. I don't know about the performance impact though.
protected synchronized void addToCache(String name, Vector<URL> resources) {
lruCache.put(name, resources);
}Achim Nierbeck commented
adding synchronization:
master:
https://github.com/ops4j/org.ops4j.pax.web/commit/022e0d507bb2d5042eaea25ed2432123e774536f
ops4j-issues
commented
8 years ago ops4j-issues
commented
8 years ago Jon Anstey commented
Released under 4.2.7.
Jan Kreutzfeld created PAXWEB-959
I'm trying to use our application in Karaf 4.0.4 (instead of 3.0.3), but encounter the following exception at runtime:
I get alot of those with different keys that cannot be added since the lruCache is full. Its size is set to 100 in the code, which is not enough in this case. Shouldn't this be configurable? Or am I doing something fundamentally wrong for this to happen?
As you can see from the stacktrace, we are using the ZK framework, which is not very OSGi friendly. I extracted the content of the lruCache at the time the exception occured. Maybe it is useful:
Affects: 4.2.4 Fixed in: 4.2.6, 4.2.7, 6.0.0 Votes: 0, Watches: 3