Upgrade JSP version to 2.2 [PAXWEB-304]

[ops4j-issues]

Achim Nierbeck created PAXWEB-304

---

Affects: 3.0.0.M1, 3.0.0.M2, 3.0.0.M3 Fixed in: 4.0.0 Attachments:

• PAXWEB-304_Upgrade_JSP_to_2_2-v1-notworkingyet.patch
• PAXWEB-304_Upgrade_JSP_to_2_2-v1-notworkingyet_2.patch

Votes: 1, Watches: 2

---

Referenced issues

relates to:

• 832 - Support Jetty 9.0 [PAXWEB-520]

[ops4j-issues]

Serge Huber commented

According to the plugin documentation it should be still doing that, is it not the case ?

http://wiki.eclipse.org/Jetty/Feature/Jetty_Jspc_Maven_Plugin

Also when upgrading to Jetty 9 we should upgrade the dependency.jetty.version value to make sure it uses the latest version of the plugin.

Best regards,
Serge Huber.

[ops4j-issues]

Achim Nierbeck commented

We have to differentiate.
One thing is the actual pre-compilation and second is the usage of the pre-compiled JSPs in pax-web.
For the second we need to switch to the now different way of providing pre-compiled JSPs and tbh it's quite a hassle.
Now for the precompilation it look a lot like I'm in need of using another JSPC plugin since the one used in the past doesn't play nicely with the way the now tomcat based jasper works.
I'm still experimenting but it looks a lot like I need to switch to another JSPC plugin.

[ops4j-issues]

Serge Huber commented

You are right even I'm getting confused.

Since we are using Tomcat Jasper to compile, we need a precompiler that uses the same version of Jasper.

It seems this one supports pluggeable implementations of the compiler :
http://mojo.codehaus.org/jspc/jspc-maven-plugin/

Otherwise another solution would be to call the Ant JspC task using the Maven Ant plugin.

Best regards,
Serge Huber.

[ops4j-issues]

Achim Nierbeck commented

yep, got it working now.
Only the Karaf-Itests fail right now, due to some strange issue with the JDT.
Hopefully will push shortly...

[ops4j-issues]

Serge Huber commented

Very nice thanks for all the work !

What's the issue with the Karaf itest ?

Best regards,
Serge Huber.

[ops4j-issues]

Achim Nierbeck commented

I'm down to
Manifest not present in the first entry of the zip
which I'm working around with a wrap: url-handler :/
After that it seems to work, now it's just some more minor dependency stuff.
I'm sure I'm gonna push soon ...

[ops4j-issues]

Achim Nierbeck commented

Fixed in Branch:
Branch: refs/heads/PAXWEB-304
Home: https://github.com/ops4j/org.ops4j.pax.web
Commit: 330acea7232cf255bca24971c974f2fcd0fecb95
https://github.com/ops4j/org.ops4j.pax.web/commit/330acea7232cf255bca24971c974f2fcd0fecb95
Date: 2013-05-10 (Fri, 10 May 2013)

---

leaving it open till it's merged to trunk!

[ops4j-issues]

Serge Huber commented

Ok is there anything to do before the merge to trunk ?

[ops4j-issues]

Achim Nierbeck commented

Nope, just merging ... and testing.

[ops4j-issues]

Serge Huber commented

Once the merging is done I'll try to find some time to test it here. Thanks for all the hard work.

[ops4j-issues]

Achim Nierbeck commented

Branch: refs/heads/master
Home: https://github.com/ops4j/org.ops4j.pax.web
Commit: 9b744db273fb59668d65bbff42a854f4284d9202
https://github.com/ops4j/org.ops4j.pax.web/commit/9b744db273fb59668d65bbff42a854f4284d9202
Date: 2013-03-18 (Mon, 18 Mar 2013)

---

merged to master branch

[ops4j-issues]

Serge Huber commented

Did a quick compilation check here and I can validate that all tests are working.

[ops4j-issues]

Achim Nierbeck commented

Unfortunately the equinox itests failed,
just seen it. Should have checked it before.
http://ci.ops4j.org/jenkins/job/org.ops4j.pax.web-itest-equinox/43/

[ops4j-issues]

Achim Nierbeck commented

now it should also work with equinox.
https://github.com/ops4j/org.ops4j.pax.web/commit/22f336d26304d29cf03bf34eeec1a85a48c3c509