opsdisk / pagodo

pagodo (Passive Google Dork) - Automate Google Hacking Database scraping and searching
GNU General Public License v3.0
2.67k stars 487 forks source link

Wrong number of contents in ghdb_scraper.py #7

Closed SergioP3rez closed 6 years ago

SergioP3rez commented 6 years ago

Hi, there is an error in ghdb_scraper.py, in lines 34 and 35. I solved it changing actual lines by these:

column = table.find_all('td')[2]
dork = column.find_all('a')[0].contents[0]

With this, it is retrieving correctly the google dork from the table that is actually shown in https://exploit-db.com/ghdb//

Regards!

opsdisk commented 6 years ago

Thanks for the heads up @SergioP3rez ...I'll take a look and push a fix if it needs it.

SergioP3rez commented 6 years ago

@opsdisk no problem, it is a pleassure to contribute! If you want, since I have already made the fix in the code, I can generate a pull request that you would only have to validate :)

opsdisk commented 6 years ago

That works even better!

SergioP3rez commented 6 years ago

Ok! I will do it then.

Regards and thanks for your work!

SergioP3rez commented 6 years ago

@opsdisk Excuse me, you should give me permissions to contribute to this repository, i can not push my changes If you do not give me the required permissions :)

remote: Permission to opsdisk/pagodo.git denied to SergioP3rez.
fatal: unable to access 'https://github.com/opsdisk/pagodo.git/': The requested URL returned error: 403

Thanks in advance!

opsdisk commented 6 years ago

The github workflow I'm familiar with is to clone this repo to your local box

git clone https://github.com/opsdisk/pagodo.git

create a new branch, add file, and commit it.

git checkout -b myfix
git add somefile.py
git commit -m "fixed thing"

push it to your github repo

git push origin https://github.com/SergioP3rez/pagodo.git

then request a PR through the web interface.

SergioP3rez commented 6 years ago

@opsdisk Yes, that is the workflow that i followed, but I think I must do a fork or similar. I will try forking the project and retry.

SergioP3rez commented 6 years ago

Done! Now you can review my pull request and merge it to master if it looks good to you.

Regards and thanks again!