opserver / Opserver

Stack Exchange's Monitoring System
https://opserver.github.io/Opserver/
MIT License
4.51k stars 828 forks source link

Server Status due to Ping #268

Closed JoshKeegan closed 6 years ago

JoshKeegan commented 7 years ago

Hi, We're just starting to use OpServer in production; so first of all, thanks it's looking great!

One small thing we've noticed though is that all of the servers we're monitoring (so far) apart from the one running bosun show with a warning: image

Looking in the code it seems to be in BosunDataProvider.GetNodeStatus they're being marked as unreachable by:

if (host.ICMPData?.Values.All(p => p.TimedOut) == true)
    return NodeStatus.Unreachable;

This makes sense as we don't operate internal DNS and so server hostnames won't be resolved to IPs & Bosun won't be able to ping the servers. Is there a setting to disable no ping producing a warning?

For now, I expect we'll just comment those lines. Cheers, Josh

NickCraver commented 6 years ago

I've pushed a new option in latest to ignore the ping status, like this:

  "providers": {
    "bosun": {
      "host": "...",
      "apiKey": "...",
      "ignorePing": true
    }

Please let me know if you have any issues!