NickCraver
commented
6 years ago I'm not against adding the feature for certain, but do have issues with the current form. Keep in mind that Opserver monitors many node types: Windows, Linux, Network gear, VM clusters, etc. If you look at the properties of a service here, they're just a service. How they're implemented and queried would be per-provider but they are still just services and general purpose at that. The same services exist on systemd in *nix for example.
Some initial thoughts:
- Win32Service should be a more generic "NodeService"
- Lots of extra properties on this class, should remove the unused
- I'd remove the Where clause, this again ties very stringently to a specific provider in a specific setup and requires knowing WQL. Instead, we should have a simple regex filter that matches the service name. This way we query all, but filter the display. This is also consistent with how the dashboard config itself works (and is intentionally agnostic)
- The title in the view shouldn't have "Windows"
- View file name should be Node.Services
- What's the data-val significance in the service view loop iteration? We can't depend on anything here as an index as race conditions with add or removal from the sequence in a future poll during a click aren't safe...we should use something unique there: the service name.
I think this would be a good addition with the changes above, and we could enhance this with button controls like SQL Server jobs already have. I'd have mutability per-provider and per-node, as it'd set whether or not it can manage services on the node (e.g. do we have permissions on the server?). This would allow:
- Displaying services if that's all we can do
- Providing controls if we have the means to actually control the node (which is like WMI-only for now, as we're not investing in Orion much these days)
Thanks for the work here, I'm excited about this - let me know what you think about the brain dump above!
KennethScott
Submitting this pull request regarding issue #292 I opened looking for feedback on adding inquiry support for windows services via the WMI provider.
In a nutshell, I added a new Windows Services partial view underneath the Interfaces on the node details page. You control which services are monitored via a new DashboardSettings property that can be specified at the global, category, or perNodeSettings levels. The property itself is literally the WQL WHERE clause you want to use to select the services (i.e. 'Name = 'W3SVC') so you have full control over which ones you're monitoring on which servers.
I'm hoping this is something you'll consider merging in as I really do think it adds value to see the status of various services. My next goal is to add a couple of buttons to start and stop the services similar (cosmetically) to how you did the sql agent jobs.
Screenshot:
Thanks-