search

opserver / Opserver

Stack Exchange's Monitoring System
https://opserver.github.io/Opserver/
MIT License
4.5k stars 827 forks source link

Decimal Params not being generated properly in SQL Plan Detail view #313

Closed elvishfiend closed 6 years ago

elvishfiend commented 6 years ago

In the SQL Plan Detail view, the list of Compiled Params seems to bug out if there's a decimal param. The decimal param is missing its scale, and missing the trailing comma. There's also an additional list of params that don't show on other plan details.

This means that you can't just copy the query from OpsServer into SSMS like you can with other plan details.

image

NickCraver commented 6 years ago

I pushed a fix up for this, thanks for the heads up and let me know if there are any other problems with it!

elvishfiend commented 6 years ago

@NickCraver Seems to be working fine, thanks.

elvishfiend commented 6 years ago

@NickCraver looks like it's still got the issue where it's including the param types just before the SELECT I.e. (@p0 char(1),@p1 decimal(35,6),@p2 decimal(35,6),@p3 char(1)) in the original pic