search

opserver / Opserver

Stack Exchange's Monitoring System
https://opserver.github.io/Opserver/
MIT License
4.51k stars 828 forks source link

Idea for #392 #393

Closed NickCraver closed 3 years ago

NickCraver commented 3 years ago

For your thoughts @deanward81 - cleaner/worse? I'm torn but think it's maybe a net win, so laid it out for eyes at least!

Thinking: if we do need to enumerate versions, instead of creating sets later or known sets, users can easily pipe together any irregular collections as well...though I have no clue how likely this'll be.

deanward81 commented 3 years ago

@NickCraver I'm not sure flags will work here - the values that come out of the EngineEdition property in SQL map directly to the enum values in code - would need to map them for it to work!

NickCraver commented 3 years ago

oh right - okay I'll take a peek at proxy there (maybe attribute-based), think it does make the rest cleaner though...or not so much?

deanward81 commented 3 years ago

+1 cleaner and easier to combine, I like it - if we can make it work when it comes back from the props query then yay!