Update nugets build errors on Opserver ASP

opserver / Opserver

Stack Exchange's Monitoring System

https://opserver.github.io/Opserver/

MIT License

4.51k stars 828 forks source link

Update nugets build errors on Opserver ASP #400

Closed fasteddys closed 2 years ago

fasteddys commented 2 years ago

Hello I am getting errors on latest NuGet updates, with asp CORE 6, can you please update and check in.

NickCraver commented 2 years ago

@fasteddys Which branch are you updating here? I'd imagine there are maybe some build errors on net6.0 for the craver/aspnetcore - I'm not primary on this at the moment but will take a poke tonight.

fasteddys commented 2 years ago

Hi @NickCraver you are correct it is the AspNetCore, it was very few, like only 6 or 7 errors.

I was able to fix 4 of those easily by swapping out the deprecated namespaces / function calls.

NickCraver commented 2 years ago

@fasteddys I'm taking a look but will need someone to give it a spin and see if everything still works. Doing a lot of other net6.0 love at the same time.

NickCraver commented 2 years ago

@fasteddys I opened a PR here but can't test at the moment, if you're able to give it a go... https://github.com/opserver/Opserver/pull/401

fasteddys commented 2 years ago

Thanks I am trying it now, the build was smooth, polite reminder, some of the Nugets are showing out of date (select the MyGet option From stackoverflow and then the Nuget V3 for nuget packages sources)

Is there some guidance on how to contribute with some Modules/new functionality or how to extend this, perhaps a picture / hooks / components / architecture

From MyGet

From Nuget