search

opsgenie / kubernetes-event-exporter

Export Kubernetes events to multiple destinations with routing and filtering
Apache License 2.0
1.04k stars 351 forks source link

Implement shoutrrr #81

Open mblaschke opened 4 years ago

mblaschke commented 4 years ago

Instead of implementing services into the service use shoutrrr to attach to all supported systems

mustafaakin commented 4 years ago

It can be nice, but what about the custom layouts? How can we send customized messages to them? Also core notification functionality would be dependent on that project which I'm not comfortable with it because of the commitment it would require. If it turns about to be abandoned, forking and maintaining it will be a much more challenge.

mblaschke commented 4 years ago

shoutrrr only handles the message delivery, message customisation has to be done before (eg. using a templating system). It would allow a wider range of services and also offers proper Mattermost support (I'm interrested in it because my company doesn't allow Slack).

Isn't it better to use such a solution than reinventing the wheel for each message system? The same discussion you can have with any library, what happens when it's dropped? Either fork it or switch to another solution even if this brings breaking changes.. and maybe this never happens.