Fix for Support for behind web proxy #39

opsgenie / opsgenie-configuration-backup

Backup your OpsGenie account's configuration and restore it later

https://opsgenie.com

Apache License 2.0

28 stars 26 forks source link

Fix for Support for behind web proxy #39 #50

Open ibre5041 opened 1 year ago

ibre5041 commented 1 year ago

This RP addresses these issues:

Support for behind web proxy #39, The core of application already works fine behind proxy, but accessing rete-limit API does not respect JVM proxy setting
Log4j version was upgraded to 2.17.2
Source and Target version was upgraded to Java 1.8
Last patch is workaround for faulty RateLimitManager.getApiLimitForDomain(...) returns 0 for threadCount and then following line:
```
pool = Executors.newFixedThreadPool(threadCount);
```

throws IllegalArgumentException.

vojtechDB commented 1 year ago

proxy setting could be used if this PR would be merged in this way:

java -Dhttp.nonProxyHosts="github.mycompany.com" -Dhttps.proxyHost=192.168.100.1 -Dhttps.proxyPort=8080 -jar OpsGenieExportUtil-0.xx.xx.jar .......

sampath-kolisetty commented 1 year ago

@ibre5041 @vojtechDB Please update your branch with latest master and resolve conflicts.

vojtechDB commented 1 year ago

@sampath-kolisetty new PR with solved conflict created https://github.com/opsgenie/opsgenie-configuration-backup/pull/55

idi2022 commented 1 year ago

Hello, @sampath-kolisetty @@ibre5041 @vojtechDB and thanks for all the edits can we know when we will have the new version because we are blocked by the proxy from ni internal gitlab thank you