search

opsgenie / opsgenie-go-sdk-v2

Opsgenie GO SDK v2
Apache License 2.0
34 stars 63 forks source link

Support service tags on creation. #57

Closed multani closed 4 years ago

multani commented 4 years ago

The API doesn't expose updating tags yet: https://docs.opsgenie.com/docs/service-api#update-service

This is needed for https://github.com/opsgenie/terraform-provider-opsgenie/issues/144 and https://github.com/opsgenie/terraform-provider-opsgenie/pull/149

I'm looking for suggestions for the tests!

ffahri commented 4 years ago

@multani is there anything left to add this pr ? if not you can set as a ready for review

multani commented 4 years ago

@multani is there anything left to add this pr ? if not you can set as a ready for review

I think that's it! If you have any suggestions for better tests, I can add them!

I think the fail build is unrelated though.

multani commented 4 years ago

(as a side note, it would be great to expose updating tags on the API as well!)

multani commented 4 years ago

Closing + reopening for triggering the CI build