Encode + in e-mail addr (Team Member API)

opsgenie / opsgenie-go-sdk-v2

Opsgenie GO SDK v2

Apache License 2.0

34 stars 63 forks source link

Open arnisoph opened 4 years ago

arnisoph commented 4 years ago

As of https://docs.opsgenie.com/docs/opsgenie-go-api-v2#samples-for-team-member-sdk the user (dev) should encode the plus char in e-mail addr. I propose doing it in the SDK here. Are there any reasons why it's not solved in the go sdk already? The sdk is taking care of all the REST HTTP actions anyway?

If you use MemberIdentifierType as "username" and your username includes "+" character, you need to encode "+" as "%2B".

arnisoph commented 4 years ago

hmm I have to admit, I don't get an error when using an addr containing + but not manually encoding it. Is the warning in the docs still valid?