search

opsgenie / opsgenie-go-sdk-v2

Opsgenie GO SDK v2
Apache License 2.0
34 stars 63 forks source link

Add SendViaOEC and SendViaMarid to API Integration Request #94

Closed mcbrineellis closed 2 years ago

mcbrineellis commented 2 years ago

I opened an issue on terraform-provider-opsgenie (https://github.com/opsgenie/terraform-provider-opsgenie/issues/285) because I was unable to create an integration with the type "Zabbix" as it was missing the bool sendViaOEC or sendViaMarid as required by the API.

I tested the changes by adding the required *bool to the APIBasedIntegrationRequest struct in the SDK, and then adding the fields to createApiIntegration on the Terraform Provider.

I was successfully able to compile and create a Zabbix integration with the provider on my local machine.

I also removed two apparently erroneous spaces in result.go JSON (my system was complaining about them).

Please can you review and approve my change?

mcbrineellis commented 2 years ago

Closing this PR as the issue was API related and resolved by Atlassian: https://jira.atlassian.com/browse/OPSGENIE-177