opsgenie / opsgenie-heartbeat

OpsGenie Heartbeat Monitoring clients, and other related utilities
Apache License 2.0
14 stars 13 forks source link

Refactoring and send continues heartbeat #3

Closed arminc closed 7 years ago

arminc commented 9 years ago

I wanted to add the possibility to send continues heartbeats by a specified interval but before doing that I did some refactoring. I apologies for such a big PR but I thought you may find it interesting.

What is in the PR:
halitokumus commented 9 years ago

Thank you very much @arminc , for this collaboration. I'll take a look at this in the next week, hopefully.

arminc commented 9 years ago

In this PR the app stops when an error or a timeout happens, this is not that nice when running in a production environment. A network hiccup should not stop the app. I have fixed this by removing the exit and trowing the errors up. Code does get more if err checks but now the decision to stop or now can be made on a higher level. Besides that I also fixed some golint warnings.

The changes stack on top op this PR and you can find them here: https://github.com/arminc/opsgenie-heartbeat/tree/retry

I haven't merged them in here but I can if you want to.

cglrkn commented 7 years ago

Hi,

We updated our plugin to use APIv2 and added logging capability to the plugin as you suggested. However, we couldn't accept your pull request since it is designed to use APIv1. Thank you for your collaboration.

Best Regards