search

opsgenie / terraform-provider-opsgenie

Terraform OpsGenie provider
https://registry.terraform.io/providers/opsgenie/opsgenie/latest/docs
Mozilla Public License 2.0
100 stars 135 forks source link

fix resourceOpsGenieServiceIncidentRuleRead to detect deletion from UI #394

Closed arjunrajpal closed 1 year ago

arjunrajpal commented 1 year ago

This fixes https://jira.atlassian.com/browse/OPSGENIE-1563.

umitulusoy commented 1 year ago

@arjunrajpal Overall LGTM, can we also implement tests in the related test file to assert the change? not sure but this might responsible test source: resource_opsgenie_service_incident_rule_test.go

arjunrajpal commented 1 year ago

@arjunrajpal Overall LGTM, can we also implement tests in the related test file to assert the change? not sure but this might responsible test source: resource_opsgenie_service_incident_rule_test.go

As discussed this would require adding tests in acceptance tests and at present we do not run them as part of CI.