Closed gjacquet closed 10 months ago
This is basically the same fix as #390
@gjacquet could you refer #390 and make similar changes throughout the file?
@koushik-swaminathan This is what I did but I missed a few spots that I addressed this morning. I ran a few test on my project and it seems to address my issue.
@gjacquet alright let me test it out and get back to you
Hi @gjacquet , just an FYI. When you commit a binary and delete it in a subsequent commit, the binary is still stored in the repository. You would need to rebase and squash your commits together to properly delete the binary from the initial commit that introduced it.
@Baarsgaard Done! I guess I am more used to the Github squash and merge feature that does all of this as the PR is getting merged.
Hi @gjacquet, another PR has already included these changes along with a few others so I'll be merging that instead. Thank you!
@koushik-swaminathan sounds good! Out of curiosity, could you please send the link to the other PR addressing this issue? It seems to be #404, is it correct? Do you have an ETA on the next provider release?
This should address #409.
Conditions and restrictions should be Sets rather than Lists.