Closed ogenstad closed 4 weeks ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Files with missing lines | Patch % | Lines |
---|---|---|
infrahub_sdk/transfer/exporter/json.py | 0.00% | 1 Missing :warning: |
@@ Coverage Diff @@
## develop #108 +/- ##
========================================
Coverage 64.27% 64.27%
========================================
Files 74 74
Lines 6856 6856
Branches 1355 1355
========================================
Hits 4407 4407
Misses 2098 2098
Partials 351 351
Flag | Coverage Δ | |
---|---|---|
python-3.10 | 43.26% <0.00%> (ø) |
|
python-3.11 | 43.26% <0.00%> (ø) |
|
python-3.12 | 43.26% <0.00%> (ø) |
|
python-3.9 | 43.20% <0.00%> (ø) |
|
python-filler-3.12 | 23.89% <0.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing lines | Coverage Δ | |
---|---|---|
infrahub_sdk/transfer/exporter/json.py | 19.79% <0.00%> (ø) |
Upgrade ruff and fix an issue with ruff rule: RUF031 [*] Avoid parentheses for tuples in subscripts.
This is mostly to fix an issue related to python SDK being on an earlier version compared to infrahub server.
So in the server code we'd get:
I think it's because RUF031 probably didn't exist in ruff 0.5.0 so it was not disabled in the SDK config.
We could also disable checking within the SDK directory from the main project but I think it's quite convenient to be able to have everything in one command when working against both code bases.