bug: infrahubctl generator command "swallows" useful information in error messages

[wvandeun]

Component

Python SDK

Infrahub version

0.12.1

Current Behavior

infrahubctl generator command seems to swallow useful information when you run into some error conditions:

• when you access a non existing key in a dictionary you get an error message blabla in this case is the string value of the key we tried to access

• when you pass a wrong type to a filter for a graphql query using the client.get method

In a large generator script it could be hard to figure out where exactly these conditions happened. Using --debug does not seem to provide more information.

Expected Behavior

• can we print the line where the error condition happened in the generator?
• can we provide more information on the type of exception that happened
• --debug could provide us the complete exception / traceback

Steps to Reproduce

• create a group called testing_targets in Infrahub
• do not any member to the group
• define a git repository on your file system
• create a .infrahub.yml config file with this contents

  ---
  generator_definitions:
  - name: "testing"
  file_path: "generators/testing.py"
  class_name: "Generator"
  targets: testing_targets
  query: testing
  parameters:
    name: "name__value"

• create a file generators/testing.py

  
  from infrahub_sdk.generator import InfrahubGenerator

class Generator(InfrahubGenerator): async def generate(self, data: dict) -> None: print(data["invalid key"])

- create a file `generators/testing.gql`
```graphql
query testing($name: String!) {
  BuiltinTag(name__value: $name) {
    edges {
      node {
    name {
      value
    }
      }
    }
  }
}

• run infrahubctl generator testing
• change the print statement in generators/testing.py

  self.client.get("BuiltinTag", name__value="aaa")

• run infrahubctl generator testing

Additional Information

No response

[gmazoyer]

It seems that the first part of this issue has been taken care of when we fixed error handling in infrahubctl. The second part where we have String cannot represent a non-string value error, is something that needs addressing in the backend. This is actually the raw error from the GraphQL API. Should we relocate this issue to the backend repo?

[dgarros]

It seems that the first part of this issue has been taken care of when we fixed error handling in infrahubctl. The second part where we have String cannot represent a non-string value error, is something that needs addressing in the backend. This is actually the raw error from the GraphQL API. Should we relocate this issue to the backend repo?

Yes