opsmill / infrahub

Infrahub - A new approach to Infrastructure Management
https://opsmill.com/
GNU Affero General Public License v3.0
148 stars 7 forks source link

Update docker-compose CICD with invoke commands #3675

Open BeArchiTek opened 2 weeks ago

BeArchiTek commented 2 weeks ago

New invoke commands to :

Rework CICD file to use the Bot token on stable branch and use the 2 new invoke commands

BeArchiTek commented 2 weeks ago

@ogenstad I want to update the default *_ADDRESS for the container names instead of localhost as it's our default deployment. I want your point of view on it (it seems like we override the value everywhere for now)

@fatih-acar you are using the variables in others docker files in development/ but without default + override in the services directly, so didn't change those for now

ogenstad commented 2 weeks ago

@ogenstad I want to update the default *_ADDRESS for the container names instead of localhost as it's our default deployment. I want your point of view on it (it seems like we override the value everywhere for now)

For me it would make most sense to keep localhost as that would always be usable for local testing, however infrahub-server would only make sense within the context of our Docker environment. If we are to remove localhost I think it would be better to just remove it and change these values to be required. So that you have to specify the server names. Forcing users to set these values would also make sense for the SDK.

I'm not sure we should keep the INFRAHUB_INTERNAL_ADDRESS, to me this is a duplicate that is only used to set INFRAHUB_ADDRESS used by the SDK. I think the only reason to keep it is if we should continue supporting infrahub.toml files but I'd vote to get rid of those.