Add decorator to handle exceptions for commands

opsmill / infrahub

Infrahub - A new approach to Infrastructure Management

https://opsmill.com/

GNU Affero General Public License v3.0

192 stars 10 forks source link

Add decorator to handle exceptions for commands #3768

Closed gmazoyer closed 2 months ago

gmazoyer commented 3 months ago

Fixes https://github.com/opsmill/infrahub/issues/3506

Commands to use decorator with:

[x] infrahubctl branch
[x] infrahubctl check
[x] infrahubctl generator
[x] infrahubctl render
[x] infrahubctl run
[x] infrahubctl schema
[x] infrahubctl transform
[x] infrahubctl version

The decorator code is redundant due to having to handle both sync and async commands. Is it worth to have async commands since these have a pretty linear execution?

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #3768 will degrade performances by 33.28%

_{Comparing gma-20240704-3506 (e4db1f3) with develop (a596a13)}

Summary

❌ 1 regressions ✅ 9 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`develop`	`gma-20240704-3506`	Change
❌	`test_load_node_to_db_node_schema`	49.9 ms	74.8 ms	-33.28%

ogenstad commented 2 months ago

Also if you rebase this PR it should fix the flaky end to end tests.