opsroller / arduino

Automatically exported from code.google.com/p/arduino
Other
0 stars 0 forks source link

RW pin not correctly disabled in LiquidCrystal library. #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
"As  _rw_pin is defined as unsigned, it can never take the value -1 (it has the 
value 255) and the 
compiler optimises out the 'if' and so LOW gets written to port 255.

"Changing the type of  _rw_pin to int8_t fixes the problem."

http://www.arduino.cc/cgi-bin/yabb2/YaBB.pl?num=1256839192

Original issue reported on code.google.com by dmel...@gmail.com on 30 Oct 2009 at 6:45

GoogleCodeExporter commented 9 years ago
Now using 255 instead of -1 to disable the pin.

Original comment by dmel...@gmail.com on 18 Dec 2009 at 4:37

GoogleCodeExporter commented 9 years ago
Tested and works fine

Original comment by joe.amax...@gmail.com on 15 Jan 2010 at 4:50