optados-developers / optados

Official Repository of the Optados code
http://www.optados.org
20 stars 22 forks source link

od2od The format <-> binary file converter. #28

Closed ajm143 closed 4 years ago

ajm143 commented 4 years ago

Tried to test this for robustness and document its limitations. Now works for OME, DOME, PDOS and ELNES.

To do -- make some tests in the test suite.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@cba072c). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop     #28   +/-   ##
=========================================
  Coverage           ?   30.1%           
=========================================
  Files              ?      17           
  Lines              ?    4973           
  Branches           ?       0           
=========================================
  Hits               ?    1497           
  Misses             ?    3476           
  Partials           ?       0
Impacted Files Coverage Δ
optados/src/electronic.f90 12.17% <ø> (ø)
optados/src/pdos.F90 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cba072c...974eaa3. Read the comment docs.

jryates commented 4 years ago

This is now failing due to an issue with build.f90 This is because the script that writes build.f90 uses "git describe --tags" - this fails as the repository has no tags (perhaps @ajm143 has some uncommitted tags in his repository - hence it worked locally). If I swap the line for "git describe --always" it builds ok. But perhaps the answer is to commit some tags.

ajm143 commented 4 years ago

Oh -- I seem to have got two pull requests merged together. Let me unpick and try again. There will be three separate things happening, and they deserve a pull request each:

(1) od2od file converter (2) The --version command. (3) First attempt at automatic documentation.

Sorry, A.

jryates commented 4 years ago

Andrew - I think you still need to strip the debug print statements noted above.

ajm143 commented 4 years ago

Hi Jonathan --

Yes. I don't think I've got this right yet. At the moment I've got optados/optados ajm143/optados, ~/src/optados and ~/tmp/optados all in slightly different states. For what I believe are the right reasons.

I'm not yet competent to achieve what I need to with an optically minimal number of moves! But I think I'm learning.

jryates commented 4 years ago

It gets a bit messy working with a live pull request! Push all you need to, then drop me a note when you want me to check it over and merge.

ajm143 commented 4 years ago

Ta. I'm sure there are more elegant ways to do what I'm doing -- but at the moment I've only got one wheel on my wagon...

ajm143 commented 4 years ago

Ok -- the two debug line comments are now "outdated" so I think I've got this pull request right. Can you check and merge if you're happy.