HashPayload Transactor method can return a number of different errors - e.g. when decoding a transaction (InvalidPayload), validating a block/account (InvalidBlock, UnknownBlock etc).
In api/rosetta/payloads.go we should differentiate between those errors instead of returning internal error for everything (configuration.ErrorInternal).
Similar should be done for other callers of decodeTransaction - we not currently checking for InvalidPayload errors in general.
awfm9
commented
3 years ago
HashPayloadTransactor method can return a number of different errors - e.g. when decoding a transaction (InvalidPayload), validating a block/account (InvalidBlock,UnknownBlocketc).In
api/rosetta/payloads.gowe should differentiate between those errors instead of returning internal error for everything (configuration.ErrorInternal).Similar should be done for other callers of
decodeTransaction- we not currently checking forInvalidPayloaderrors in general.