optakt / flow-dps

Flow Data Provisioning Service
Apache License 2.0
29 stars 13 forks source link

Update protocol buffers compiler to v3.17.3 #418

Closed awfm9 closed 3 years ago

Ullaakut commented 3 years ago

As you can see, unless we make some changes, rerunning go generate after the version upgrade has no effect on the headers of the generated code:

// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
//  protoc-gen-go v1.26.0
//  protoc        v3.17.0
// source: api.proto

This is because the way our go generate target was built was wrong. It never ever regenerated the contents of api.pb.go but only added tags to it.

This is fixed in https://github.com/optakt/flow-dps/pull/420, which also upgrades the version of protoc.