Add sanity check for mismatch in execution state

optakt / flow-dps

Flow Data Provisioning Service

Apache License 2.0

29 stars 13 forks source link

Add sanity check for mismatch in execution state #458

Closed Ullaakut closed 3 years ago

Ullaakut commented 3 years ago

Goal of this PR

Fixes #395

Additional Notes

This PR does not test the case where a mismatch occurs, since we can't test code that calls log.Fatal() without making a wrapper around zerolog logger and using that everywhere.

Checklist

[x] Is on the right branch
[x] Documentation is up-to-date
[x] Tests are up-to-date

awfm9 commented 3 years ago

@Ullaakut I think we can just add an additional transition for this check, and make it possible to disable it with a config flag.

Ullaakut commented 3 years ago

@awfm9 Since your PR already modifies the transitions/statuses, I'll take my time on time one to avoid conflicts. I'll focus on the Rosetta stuff until it gets merged, and will update this one afterwards, should be fairly quick.

Ullaakut commented 3 years ago

Tests will pass and it will be ready for review once #79 is fixed.