Closed Ullaakut closed 2 years ago
Just realized I had forgotten to push the engine system earlier this week. I pushed it and also rebased on master while I was at it.
@awfm9 There's one remaining thread that is not resolved, but since I think it's a very minor detail, I'll merge it as is and if you insist that my decision was wrong, we can always make a small PR to change it later.
Goal of this PR
Fixes #374
Checklist
Does the PR require tests to be added or updated?
Since this PR only modifies the
main
packages, it should not impact existing tests. Adding tests to theComponent
package might or might not make sense depending on which design ends up being accepted.Does the PR require documentation to be added or updated?
This does not fundamentally change the architecture in any meaningful way, it just wraps our components, so it should not require any new documentation besides code comments.
It is not complete since it only showcases the proposed systems for two of our binaries at the moment.
Misc