Previously, allOf patches didn't work - this was because we were applying additionalProperties: false to every variant of allOf, meaning that they failed. What we needed was unevaluatedProperties which is only available in draft2019+. We want to set unevaluatedProperties on allOf, and additionalProperties: true to every allOf's direct children
This also means draft4 evaluation doesnt work - not really sure how this would work with OAS3, but the case we do know about we can handle
exclusiveMaximum + exclusiveMinimum are boolean -> we convert to max / min with +-1 offset
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?
🍗 Description
What does this PR do? Anything folks should know?
Previously, allOf patches didn't work - this was because we were applying
additionalProperties: falseto every variant of allOf, meaning that they failed. What we needed was unevaluatedProperties which is only available in draft2019+. We want to setunevaluatedPropertiesonallOf, and additionalProperties: true to every allOf's direct childrenThis also means draft4 evaluation doesnt work - not really sure how this would work with OAS3, but the case we do know about we can handle
📚 References
Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.
👹 QA
How can other humans verify that this PR is correct?