opticdev / optic

OpenAPI linting, diffing and testing. Optic helps prevent breaking changes, publish accurate documentation and improve the design of your APIs.
https://useoptic.com
MIT License
1.35k stars 79 forks source link

Revert "fix polymoprhic with nullable patching (#2636)" #2638

Closed niclim closed 8 months ago

niclim commented 8 months ago

This reverts commit 2849178872145d8e1b3bdfdc1f7bd304a6722d97.

🍗 Description

What does this PR do? Anything folks should know?

reverts pr to support nullable - for some reason my test that i wrote didn't trigger the failing path, but running it with that schema in the full capture flow triggers this error

  stack: 'Error: Error compiling schema: "nullable" cannot be used without "type"\n' +
...

📚 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

👹 QA

How can other humans verify that this PR is correct?