search

opticdev / optic

OpenAPI linting, diffing and testing. Optic helps prevent breaking changes, publish accurate documentation and improve the design of your APIs.
https://useoptic.com
MIT License
1.35k stars 79 forks source link

Fix/tests for node 20 #2669

Closed niclim closed 8 months ago

niclim commented 8 months ago

🍗 Description

What does this PR do? Anything folks should know?

📚 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

👹 QA

How can other humans verify that this PR is correct?

niclim commented 8 months ago

Not sure how this snapshot error occured in https://github.com/opticdev/optic/actions/runs/7572637075/job/20623205680#step:6:290

[@useoptic/optic]:       POST /books
[@useoptic/optic]:         × Request Body
[@useoptic/optic]:     +   [request body] body is required and missing
[@useoptic/optic]:         [200 response body] body is not documented
[@useoptic/optic]:         [request body] 'price' does not match type string. Received 1 (/properties/price)
[@useoptic/optic]:     -   [request body] body is required and missing

But it didn't happen here... Seems like it's just terminal output being flushed out in a different order