search

opticdev / optic

OpenAPI linting, diffing and testing. Optic helps prevent breaking changes, publish accurate documentation and improve the design of your APIs.
https://useoptic.com
MIT License
1.35k stars 79 forks source link

implement swagger 2 validation #2772

Closed niclim closed 6 months ago

niclim commented 6 months ago

🍗 Description

What does this PR do? Anything folks should know?

📚 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

👹 QA

How can other humans verify that this PR is correct?

niclim commented 6 months ago

Looks good. I got a little confused by the difference between basic and the full schema, but figured out you were using it when strict validation was turned off

We have the same idea with the openapi 3 validator, so this is to match the functionality (I think we initially did this to try match the minimum typings) but I could see us moving away to not validate anything here